[fix](nereids) do not use mv that requires union when union rewrite i…#64207
Draft
yx-keith wants to merge 1 commit into
Draft
[fix](nereids) do not use mv that requires union when union rewrite i…#64207yx-keith wants to merge 1 commit into
yx-keith wants to merge 1 commit into
Conversation
…s disabled (apache#59593) When a partitioned mv misses some queried partitions, union compensation with the base table is required to produce a complete result. The partition-compensation branch was gated by enable_materialized_view_union_rewrite, so when that flag was false the whole branch was skipped and the partial mv-only plan was used as the rewrite result, silently dropping the rows of the uncovered partitions. Compute the invalid partitions regardless of the flag, and bail out (the mv can not be used for this query) when the mv actually needs union compensation but union rewrite is disabled - same handling as when union compensation can not be done because of the query structInfo. When the mv covers all queried partitions (no union needed) the mv is still used as before, so the flag only affects mvs that genuinely require union. Add a regression test that, with the flag off and an mv missing a base-table partition, asserts the mv is not chosen and the query still returns the complete result.
yx-keith
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s disabled (#59593)
When a partitioned mv misses some queried partitions, union compensation with the base table is required to produce a complete result. The partition-compensation branch was gated by enable_materialized_view_union_rewrite, so when that flag was false the whole branch was skipped and the partial mv-only plan was used as the rewrite result, silently dropping the rows of the uncovered partitions.
Compute the invalid partitions regardless of the flag, and bail out (the mv can not be used for this query) when the mv actually needs union compensation but union rewrite is disabled - same handling as when union compensation can not be done because of the query structInfo. When the mv covers all queried partitions (no union needed) the mv is still used as before, so the flag only affects mvs that genuinely require union.
Add a regression test that, with the flag off and an mv missing a base-table partition, asserts the mv is not chosen and the query still returns the complete result.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)